Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples #108

Merged
merged 12 commits into from
Nov 14, 2024
Merged

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Nov 1, 2024

Updates the beyla golden signals sample, and uses the disable_informers and drop_external options. This reduces memory usage by half, and reduces CPU usage by > 90%. It also means we can get rid of our filter in the otel collector config. In a follow-up, we could replace the collector in this sample with the k8s-otlp-ingest one so we don't need to maintain it anymore here.

The routes unmatched: wildcard preserves existing behavior, which is to disable the route heuristics. It did seem to work well when I tried it with the OTel demo, but that can be removed separately.

There were a few typos in some samples, which i've fixed.

The beyla service graph sample needed the metric name "calls" updated to "traces.span.metrics.calls" because of an update to the collector component.

@dashpole dashpole marked this pull request as ready for review November 1, 2024 20:34
@dashpole dashpole requested a review from a team as a code owner November 1, 2024 20:34
@dashpole dashpole merged commit ee10f79 into GoogleCloudPlatform:main Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants